Header/2 function in mochiweb_request_bridge.erl #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accepts the header name as atom or string, if atom option is used take care that al _ are converted to -
choptastic
added a commit
that referenced
this pull request
May 31, 2012
Cowboy vs Mochiweb path handling
|
This should have been merged long ago, but never was. For that, I apologize. As it is now, mochiweb_request_bridge:header/2 exists as merged from the ChicagoBoss variation of SimpleBridge. I like how you do the atom to list conversion though, and I will likely incorporate that change tomorrow. For now, I will leave the pull request open, as it's getting late, and I simply don't have the time to complete the merger now. Thanks Manuel! |
|
Don't worry .. Thank you. |
|
There are some abstractions on this that make this more flexible in the upcoming 2.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Rusty,
I've added a header/2 function in mochiweb_request_bridge.erl to allow search for user defined headers.
Regards.